Audio-WestlakeU / NBSS

The official repo of NBC & SpatialNet for multichannel speech separation, denoising, and dereverberation
MIT License
232 stars 26 forks source link

`state` and `share_qk` options #30

Closed philgzl closed 6 months ago

philgzl commented 6 months ago

Hi again,

quancs commented 6 months ago
  • Is the state argument of the different foward methods always None in your experiments? If not, when should it be set to something different from None?

It's always None in our experiments.

When using Retention, I can see you are sharing the query and key projection layers when RoPE is disabled here. Can you explain why? This does not seem to be explained in the paper.

The sharing of query and key projection layers didn't degrade the performance in our experiments, but reduces the parameters and computational cost.

philgzl commented 6 months ago

Thanks!