search

Audio4Linux / JDSP4Linux

An audio effect processor for PipeWire and PulseAudio clients
GNU General Public License v3.0
874 stars 31 forks source link

Set number locale to C to avoid floats not parsing correctly #156

Closed Nocrex closed 10 months ago

Nocrex commented 10 months ago

The Graphic EQ and DDC settings as well as EEL scripts are not parsed correctly on machines that use a comma instead of a period for floating-point numbers.

Should resolve #128

timschneeb commented 10 months ago

This caused issues in the past, so I already forced the en_US locale (or C if en_US is unavailable) for LC_NUMERIC further down in the main.cpp file, but before anything that depends on the numeric locale is initialized: https://github.com/Audio4Linux/JDSP4Linux/blob/ad2bf82b56016ac9075042f30a13226494d65581/src/main.cpp#L216-L221 Normally, this PR shouldn't cause any difference in behavior, but maybe it really needs to be called as the first thing on startup. Anyway, I'll get rid of the old workaround and move the QLocale stuff to the top as well.