Audio4Linux / Viper4Linux

Second iteration of Viper4Linux including smarter volume management and more to come... maybe.
GNU General Public License v3.0
106 stars 11 forks source link

Specify the full path #5

Closed jeffshee closed 4 years ago

jeffshee commented 4 years ago

Hi,

Please consider specifying the full path to the binary explicitly, especially when calling the gst-launch-1.0, which casing a problem for those who have anaconda in their system. As you can see, when anaconda is installed, their binaries are actually having precedence over the system binaries, resulting in calling the wrong gst-launch-1.0.

Thanks.

❯ which gst-launch-1.0                                              [14:17:45]
~/anaconda3/bin/gst-launch-1.0
❯ conda deactivate                                                  [14:19:22]

❯ which gst-launch-1.0                                              [14:19:33]
/usr/bin/gst-launch-1.0

❯ echo $PATH                                                        [14:19:47]
/home/jeffshee/anaconda3/condabin:/usr/local/bin:/usr/local/sbin:/usr/share/Modules/bin:/usr/bin:/usr/sbin:/home/jeffshee/bin
noahbliss commented 4 years ago

@jeffshee I'll leave this open to see if any others have this issue, but I consider respecting the user's path intended functionality.

jeffshee commented 4 years ago

What if we just blacklist the binary from anaconda? Since the binary from anaconda doesn't work and giving error.

noahbliss commented 4 years ago

One workaround you could do easily is define your PATH variable in the top of the viper script. This should keep the changes local to the viper process environment, but still skip over your anaconda bins.