AudioCommons / timbral_models

Python scripts for modelling timbral attributes
Apache License 2.0
75 stars 26 forks source link

Update librosa calls to fix argument errors. #14

Open peacheym opened 1 year ago

peacheym commented 1 year ago

Currently the calls to librosa that handle onset detection breaks the timbral_extractor(...). Explicitly passing arguments fixes the issue.

gionstegmann commented 3 months ago

Hi @brayanrodbajo,

I noticed that this pull request has been approved but hasn't been merged yet, although the modifications provided by @peacheym seem to solve the issue. Could we get an update on the status of this merge?