AudioCommons / timbral_models

Python scripts for modelling timbral attributes
Apache License 2.0
75 stars 26 forks source link

Deprecation of sklearn #18

Open f-brinkmann opened 8 months ago

f-brinkmann commented 8 months ago

Your https://github.com/AudioCommons/timbral_models/blob/master/setup.py depends on sklearn, which is now deprecated. The suggested fix is to use scikit-learn instead.

Does someone have the time to try this? For some reason I get an error when trying to clone the repository. The easiest way to try might be

f-brinkmann commented 8 months ago

@Rodsis, @AndyP103, @ffont pull request #17 does this , but it seems to do more than changing setup.py. Maybe a simple pull doing only this could be merged quickly to release a new version of timbral_models. I would consider this a bug and our students are currently having trouble using timbral_models at all.

gionstegmann commented 3 months ago

@f-brinkmann I have created a focused pull request that addresses only the update from sklearn to scikit-learn in the setup.py file. This should ensure compatibility without the additional changes included in pull request #17