Replace deprecated sklearn with scikit-learn in dependencies

AudioCommons / timbral_models

Python scripts for modelling timbral attributes

Apache License 2.0

78 stars 26 forks source link

Replace deprecated sklearn with scikit-learn in dependencies #19

Closed gionstegmann closed 6 months ago

gionstegmann commented 6 months ago

Updated the dependency list in setup.py to replace the deprecated sklearn package name with the current scikit-learn.

This update addresses the issue described in #18, where installation failures occur due to the outdated 'sklearn' package name.

f-brinkmann commented 6 months ago

Hi, thats great - thanks! I just tried a pip install -e . with Python 3.12.3 on MacOs and it worked right away. The only think I noticed is that sklearn is still mentioned in the readme.

@alastair, @ffont can this be merged and released?

gionstegmann commented 6 months ago

sklearn is still mentioned in the readme.

fixed 👍