AudioKit / AudioKitSynthOne

AudioKit Synth One: Open-Source iOS Synthesizer App
http://audiokitpro.com/synth
MIT License
1.65k stars 214 forks source link

Replace ChimpKit SDK Dependency #118

Closed sieren closed 4 years ago

sieren commented 4 years ago

Hey everyone,

this PR removed the dependency on the ChimpKit SDK. Background: The ChimpKit SDK repo has not been updated in 5-6 years and is showing it's age. It does not compile when using Catalyst (Catalina) as a target and it is using the deprecated APIv2 of MailChimp. This API is well documented and I've written a little class against it.

Changes: ChimpKit is removed from PodFile. A new class called MailChimp is being put in place as a drop-in replacement with a similar API as before. Higher-level changes are therefore minimal.

New: Previously users had no choice to resubscribe when they unsubscribed in the past. This PR adds functionality and checks that - if a user had subscribed in the past, we will send him/her an "opt-in" email. The reason is that we might want to prevent malicious actors from signing up third-parties. This means:

  1. If a user subscribes for the first time, the behaviour is the same as in the past.
  2. If a user resubscribes, we will send an opt-in email.

I have tested and verified these behaviours with multiple accounts of my own. @aure @analogcode if we use ChimpKit in other AK Apps, this may be a universal suitable replacement.