search

AudioKit / AudioKitSynthOne

AudioKit Synth One: Open-Source iOS Synthesizer App
http://audiokitpro.com/synth
MIT License
1.65k stars 214 forks source link

Wrong parameter name in S1ParameterInfo array #168

Closed armarpc closed 3 years ago

armarpc commented 3 years ago

I just wanted to point out I think there's a small code error in S1DSPKernel.hpp.

On lines 495-497 it says:

{ compressorMasterMakeupGain, 0.5, 2, 4, "master compressor makeup gain", "master compressor makeup gain", kAudioUnitParameterUnit_Generic, false, NULL},
{ compressorReverbInputMakeupGain, 0.5, 1.88, 4, "reverb input compressor makeup gain", "reverb input compressor makeup gain", kAudioUnitParameterUnit_Generic, false, NULL},
{ compressorMasterMakeupGain, 0.5, 1.88, 4, "reverb wet compressor makeup gain", "reverb wet compressor makeup gain", kAudioUnitParameterUnit_Generic, false, NULL},

I think the last line should read:

{ compressorReverbWetMakeupGain, 0.5, 1.88, 4, "reverb wet compressor makeup gain", "reverb wet compressor makeup gain", kAudioUnitParameterUnit_Generic, false, NULL},

I don't think it actually affects anything, but it would still be good to correct it.

aure commented 3 years ago

Make a Pull Request!

armarpc commented 3 years ago

I created pull request #169