search

AudioKit / AudioKitUI

Controls and Visualization for AudioKit apps
MIT License
200 stars 53 forks source link

update adsrview #28

Closed eljeff closed 3 years ago

eljeff commented 3 years ago

this makes adsr more universal by using normalised values instead of tying everything to seconds / milliseconds. it also exposes some customisation features for how to display the curve (gradient, curve amount, colors, etc)

aure commented 3 years ago

This looks good to me. When I have time, I'd like to go over it a bit more. I don't like the use of "Amount" and/or "Percentage" we can probably drop those words and treat everything as a normalized value.

eljeff commented 3 years ago

I think its a little vague but I dropped amount from attack etc. Percentage I'm a little reluctant to drop though because its not clear if you just 'releasePadding' if thats pixels or percent or what. So its explicit and less confusion.

aure commented 3 years ago

Will there be a companion change to the Cookbook app? If it needs to be updated for this new adsr, that would be good. I can do it tonight if no one else gets to it first.

eljeff commented 3 years ago

I tried the cookbook, and since it was already defaulting to 1 second, the changes are actually fairly transparent

eljeff commented 3 years ago

Why is the CI failing? something about docs and an access token?

aure commented 3 years ago

Why is the CI failing? something about docs and an access token?

Not sure why the personal acces token wasn't working, I added a new one, hopefully it will work next pull request.