AudioKit / AudioKitUI

Controls and Visualization for AudioKit apps
MIT License
187 stars 52 forks source link

Add public on some visualizations views #61

Closed ipodishima closed 1 year ago

ipodishima commented 1 year ago

Motivation:

I'm working on some recording visualizations and discovered:

aure commented 1 year ago

Thanks!

Matt54 commented 1 year ago

@ipodishima - do those colors in the SpectrogramView need to be Bindings? My guess is that they can just be variables (not State or Binding)

Matt54 commented 1 year ago

Let me know if I'm off on this: https://github.com/AudioKit/AudioKitUI/pull/63

ipodishima commented 1 year ago

Those were states before, this is why I kept bindings. But I'm not sure this is useful even though it's not lost to have bindings @Matt54

Matt54 commented 1 year ago

@ipodishima I'm pretty sure I made them state when I had a "less than ideal" understanding of SwiftUI state management 😅 - I should probably do a full sweep through AudioKitUI and clean up my mess

ipodishima commented 1 year ago

Ahahaha no worries. I'm still trying to figure out the best practices for SwiftUI without being redundant, creating bugs, or having performance issues 🤣