search

AudioKit / AudioKitUI

Controls and Visualization for AudioKit apps
MIT License
187 stars 52 forks source link

Add public #65

Closed ipodishima closed 1 year ago

ipodishima commented 1 year ago

Exposing AudioHelpers

Also @aure : I replaced getFileEndTime by duration from AudioKit. Only difference is getFileEndTime uses processingFormat where duration uses fileFormat. Not sure if it has an impact...

NickCulbertson commented 1 year ago

@Matt54 might need to take a look. I think he's using this in the Cookbook's MultiSegmentPlayer: https://github.com/AudioKit/Cookbook/blob/main/Cookbook/CookbookCommon/Sources/CookbookCommon/Recipes/AudioPlayer/MultiSegmentPlayerView.swift

aure commented 1 year ago

I'm just awaiting @Matt54 to chime in that this is okay by him.

Matt54 commented 1 year ago

Hey sorry for the delay - been a crazy busy week. Looks good though!

Matt54 commented 1 year ago

@aure I've got these rms analysis methods duplicated in other projects since I didn't want the AudioKitUI dependency. Reminds of that idea of spitting off a package just for utility functions

ipodishima commented 1 year ago

Yes, I wanted to go deeper into the changes but saw that some things belong to AudioKitUI, like the loadAudioSignal. IMHO it could belong to AudioKit or like you said, a utility package.