search

AudioKit / DunneAudioKit

Sampler and Synth Instruments as well as Chorus, Flanger and Stereo Delay Effects for AudioKit
MIT License
45 stars 28 forks source link

Support Xcode 15 and Swift 5.9 compiler #14

Closed jwyterlin closed 1 year ago

jwyterlin commented 1 year ago

This PR fixes an issue that prevents to build it for Xcode 15. Because of the new Swift compiler (5.9) it's needed to include cassert header.

Here is the error compiler outputs:

Screenshot 2023-06-07 at 14 27 04 Screenshot 2023-06-07 at 14 26 41

In the build report too:

Screenshot 2023-06-07 at 14 29 21 Screenshot 2023-06-07 at 14 28 21
NickCulbertson commented 1 year ago

@jwyterlin Do the test changes need to be in this PR? The cassert header part should probably be added, but the test changes would need further review/explanation.

jwyterlin commented 1 year ago

@jwyterlin Do the test changes need to be in this PR? The cassert header part should probably be added, but the test changes would need further review/explanation.

No, they are not needed for the cassert header part.

But when I ran the unit tests, they did not pass. That was the reason I changed the tests. As I can see here now, the CI is raising other errors beyond the Test Matrix. All the failures tell us that compiler is not finding the method loadUnaligned(fromByteOffset:as:) for UnsafeRawPointer

Compilers: Swift 5.5 and 5.6 Equivalent Xcode versions: Xcode 13.3, Swift 5.6, Released at March 14th 2022 Xcode 13.0, Swift 5.0, Released at September 20th 2021

but this method is available since iOS 8.0 ( Link here )

Would it be possible to update the Xcode version? Or do you guys prefere to support these old versions too?