Closed aure closed 1 year ago
I’m traveling at the moment, so won’t be able to review this. Just adding asserts shouldn’t hurt anything. I’d say go ahead.
-shane
From: Aurelius Prochazka @.> Sent: Monday, June 19, 2023 1:27:58 PM To: AudioKit/DunneAudioKit @.> Cc: Shane Dunne @.>; Review requested @.> Subject: [AudioKit/DunneAudioKit] Adding cassert a la https://github.com/AudioKit/DunneAudioKit/pull/14 (PR #15)
You can view, comment on, or merge this pull request online at:
https://github.com/AudioKit/DunneAudioKit/pull/15
Commit Summary
File Changes
(3 fileshttps://github.com/AudioKit/DunneAudioKit/pull/15/files)
Patch Links:
— Reply to this email directly, view it on GitHubhttps://github.com/AudioKit/DunneAudioKit/pull/15, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGEAII73OZPKYEDHDQH6VTXMB4Y5ANCNFSM6AAAAAAZMFL4SY. You are receiving this because your review was requested.Message ID: @.***>
I’m traveling at the moment, so won’t be able to review this. Just adding asserts shouldn’t hurt anything. I’d say go ahead.
-shane
From: Aurelius Prochazka @.> Sent: Monday, June 19, 2023 1:27:58 PM To: AudioKit/DunneAudioKit @.> Cc: Shane Dunne @.>; Review requested @.> Subject: [AudioKit/DunneAudioKit] Adding cassert a la https://github.com/AudioKit/DunneAudioKit/pull/14 (PR #15)
You can view, comment on, or merge this pull request online at:
https://github.com/AudioKit/DunneAudioKit/pull/15
Commit Summary
File Changes
(3 fileshttps://github.com/AudioKit/DunneAudioKit/pull/15/files)
Patch Links:
— Reply to this email directly, view it on GitHubhttps://github.com/AudioKit/DunneAudioKit/pull/15, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGEAII73OZPKYEDHDQH6VTXMB4Y5ANCNFSM6AAAAAAZMFL4SY. You are receiving this because your review was requested.Message ID: @.***>