Adding cassert a la https://github.com/AudioKit/DunneAudioKit/pull/14 - Githubissues

AudioKit / DunneAudioKit

Sampler and Synth Instruments as well as Chorus, Flanger and Stereo Delay Effects for AudioKit

MIT License

45 stars 28 forks source link

Adding cassert a la https://github.com/AudioKit/DunneAudioKit/pull/14 #15

Closed aure closed 1 year ago

getdunne commented 1 year ago

I’m traveling at the moment, so won’t be able to review this. Just adding asserts shouldn’t hurt anything. I’d say go ahead.

-shane

From: Aurelius Prochazka @.> Sent: Monday, June 19, 2023 1:27:58 PM To: AudioKit/DunneAudioKit @.> Cc: Shane Dunne @.>; Review requested @.> Subject: [AudioKit/DunneAudioKit] Adding cassert a la https://github.com/AudioKit/DunneAudioKit/pull/14 (PR #15)

You can view, comment on, or merge this pull request online at:

https://github.com/AudioKit/DunneAudioKit/pull/15

Commit Summary

5718ef0https://github.com/AudioKit/DunneAudioKit/pull/15/commits/5718ef0feec39cea48ebc02f9967436d99c57bde Adding cassert a la https://github.com/AudioKit/DunneAudioKit/pull/14

File Changes

(3 fileshttps://github.com/AudioKit/DunneAudioKit/pull/15/files)

M Sources/CDunneAudioKit/DunneCore/Common/EnvelopeGeneratorBase.cpphttps://github.com/AudioKit/DunneAudioKit/pull/15/files#diff-6828b180e9982b7627976fa5ae7c17b54dc75ef55cb3a7303611fea0ff18345f (1)
M Sources/CDunneAudioKit/DunneCore/Synth/WaveStack.cpphttps://github.com/AudioKit/DunneAudioKit/pull/15/files#diff-412b69506bee24f1238bb14927f92192555fa238db7c50821325a393d99ee087 (1)
M Tests/DunneAudioKitTests/GenericNodeTests.swifthttps://github.com/AudioKit/DunneAudioKit/pull/15/files#diff-f2db06e2c638e77c30f564878818faa0f65d75964289715cbcb0d251c3c6e4ff (2)

Patch Links:

— Reply to this email directly, view it on GitHubhttps://github.com/AudioKit/DunneAudioKit/pull/15, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGEAII73OZPKYEDHDQH6VTXMB4Y5ANCNFSM6AAAAAAZMFL4SY. You are receiving this because your review was requested.Message ID: @.***>