search

AudioKit / DunneAudioKit

Sampler and Synth Instruments as well as Chorus, Flanger and Stereo Delay Effects for AudioKit
MIT License
43 stars 28 forks source link

Add voice changing to Synth() #20

Open NickCulbertson opened 8 months ago

NickCulbertson commented 8 months ago

Description

The Synth in DunneAudioKit works great, but it lacks the ability to change the oscillator voices from the Swift side. The voices also can't be changed after initialization.

Proposed Solution

Allow the user to set and change voices dynamically with AUParameters.

Describe Alternatives You've Considered

Create and expose an AUParameter to change voices.

Additional Context

No response

getdunne commented 8 months ago

I stopped development on this repo a long time ago. Anyone who wishes is welcome to fork it for their own use, but I cannot spare any time to assist.

NickCulbertson commented 8 months ago

I can tell a lot of hard, skilled work went into making this, and I know open-source development is often a thankless job. So thank you sincerely for your work on this, @getdunne!

I think the AudioKit community would like to continue using and updating this package going forward. Would you prefer a new package be created, or can we keep working on this one and change the default reviewer notification settings on GitHub?

Thanks, Nick

getdunne commented 8 months ago

Thanks Nick. I wish I could have kept up my work with AudioKit, but the project I moved on to eats up all my time. By all means continue using this, but please remove me as a reviewer. Even if I had the time, this code has already been changed so much that I no longer recognize it.

-shane

From: Nick Culbertson @.> Sent: Sunday, December 10, 2023 5:08:39 PM To: AudioKit/DunneAudioKit @.> Cc: Shane Dunne @.>; Mention @.> Subject: Re: [AudioKit/DunneAudioKit] Add voice changing to Synth() (Issue #20)

I can tell a lot of hard, skilled work went into making this, and I know open-source development is often a thankless job. So thank you sincerely for your work on this, @getdunnehttps://github.com/getdunne!

I think the AudioKit community would like to continue using and updating this package going forward. Would you prefer a new package be created, or can we keep working on this one and change the default reviewer notification settings on GitHub?

Thanks, Nick

— Reply to this email directly, view it on GitHubhttps://github.com/AudioKit/DunneAudioKit/issues/20#issuecomment-1849085303, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGEAIJH3ATJQ3IP6D4ELVLYIYQFPAVCNFSM6AAAAABAJ26OPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBZGA4DKMZQGM. You are receiving this because you were mentioned.Message ID: @.***>