Reading of SFZ improved: loop_mode=no_loop, fixes #21

AudioKit / DunneAudioKit

Sampler and Synth Instruments as well as Chorus, Flanger and Stereo Delay Effects for AudioKit

MIT License

45 stars 28 forks source link

Reading of SFZ improved: loop_mode=no_loop, fixes #21 #22

Closed mahal closed 8 months ago

mahal commented 8 months ago

Improved reading of SFZ files:

loop_mode=no_loop will no longer loop the sample

https://sfzformat.com/opcodes/loop_mode/

NickCulbertson commented 8 months ago

Wouldn't this flip the default isLooping bool for existing users that haven't set its value, like here.

Would it be possible to use something like isLooping: loopMode != "no_loop" || loopMode != "", or change the line where it is declared to be var loopMode = "no_loop"?

mahal commented 8 months ago

@NickCulbertson Thanks for reviewing. I had the feeling that I'm missing something but couldn't quite point it out; now I know. I have added the line where it is declared as this anyway is the default stated in the sfzformat.com documentation.

NickCulbertson commented 8 months ago

This looks good to me!

cc: @aure