search

AudioKit / DunneAudioKit

Sampler and Synth Instruments as well as Chorus, Flanger and Stereo Delay Effects for AudioKit
MIT License
45 stars 29 forks source link

Dev/write tests for sfz #4

Closed maksutovic closed 2 years ago

maksutovic commented 2 years ago

Per @eljeff request, I have written a test loading the Sampler() with a SFZ file. I have also added a test for loading with raw samples.

Two issues I have with the pull request.

  1. For raw samples, I need to make an updated MD5 to add to the validated checksums in order to validate the test, or I need to get the raw samples from the 12345.wav file and use that to load.

  2. The SFZ file currently does not pass the test, but not because of the crash, rather the MD5 checksum is not correct. The current testing regiment has no ability to actually test the crashes we have been seeing so I'm not sure of the utility of these tests.

Irregardless, I'd like to continue improving these tests with updating MD5s but at least to my eyes this doesn't address the current issue.

eljeff commented 2 years ago

Would you want to tweak this to use the simpler sample loading from your other project? Even if it doesn't show the problem, it's a good start. Maybe we could run it a million times and see if that hits the problem?

aure commented 2 years ago

Can you recreate this pull request please?