AudioKit / DunneAudioKit

Sampler and Synth Instruments as well as Chorus, Flanger and Stereo Delay Effects for AudioKit
MIT License
45 stars 28 forks source link

`unloadAllSamples()` was removed from `Sampler` and causes memory leaks #9

Closed christianhengst closed 2 years ago

christianhengst commented 2 years ago

After updating to >=5.4, I've noticed that the unloadAllSamples() method is not present anymore. Observing the memory usage of my app I've noticed that it increases each time that samples are loaded (via loadSFZ())

Was this an intended change?

aure commented 2 years ago

I believe it was not realtime safe. @wtholliday is that correct? You can bring it back on your own fork of course.

wtholliday commented 2 years ago

Yeah we got rid of a bunch of realtime unsafe code. How about helping us out with a decent bug report instead? Closing.