search

AudioKit / ROMPlayer

AudioKit Sample Player (ROM Player) - EXS24, Sound Font, Wave Player
http://audiokitpro.com
MIT License
530 stars 82 forks source link

Multi-Delay Mix Value Issue #10

Open osustudent opened 4 years ago

osustudent commented 4 years ago

Problem Description

After launching the app, Delay is audible in the signal while the Mix value appears to be "0":

unnamed (17)

Reproduction Steps:

Run the project in Xcode and hit any key on the onscreen keyboard.

Note that the Delay Mix value is currently set to "0".

Observed Results:

Audible Delay in the audio signal.

Expected Results:

No audible Delay as the Mix value appears to be "0".

Altering the current delayMixKnob.value = 0.0 in func setDefaults() resolves the visual issue.

However, this doesn't seem to actually resolve the initialized value for Mix in the audible signal.

I'll try to fix and submit a Pull but wanted to note the issue here.

analogcode commented 4 years ago

Thanks @osustudent, that is a great find. We would certainly welcome and encourage your participation with a pull request. Thank you!