AudioKit / Tonic

Swift library for music theory

https://www.audiokit.io/Tonic/

MIT License

154 stars 21 forks source link

Fix bug shift up #36

Closed saito-arch closed 9 months ago

saito-arch commented 9 months ago

26

I took care of this issue.

Following aure's suggestion, I first write some tests. As a result, #35 has some problems. I'm sorry.

I have considered several possibilities, but it seems to me that the condition "newLetter is B" or "newLetter is not C" is necessary. So I think the handling written in #26 is fine, but this one has less time complexity.

saito-arch commented 9 months ago

I have corrected the cause of UT's failure.