search

AudioKit / Waveform

GPU accelerated waveform view
MIT License
185 stars 13 forks source link

Change toFloatChannelData() namespace to resolve conflict with AudioKit Swift Package #5

Closed NickCulbertson closed 1 year ago

NickCulbertson commented 1 year ago

Description

toFloatChannelData is in both Waveform & AudioKit packages. Changing the name in Waveform would make life easier when using them together in the same project.

Proposed Solution

Changing the name from toFloatChannelData() to toFloatChannelDataWaveform().

Describe Alternatives You've Considered

NA

Additional Context

This is low priority. I'll get to it when I have time.

aure commented 1 year ago

Wasn't this resolved here? https://github.com/AudioKit/Waveform/pull/4

NickCulbertson commented 1 year ago

Oh yes, my mistake! I was on an earlier version of Waveform.