search

AudioNet / node-core-audio

Bindings for PortAudio giving JavaScript access to sound card samples (mostly unmaintained)
MIT License
330 stars 68 forks source link

Port to NAN #43

Closed zhangyuanwei closed 9 years ago

notthetup commented 9 years ago

:+1:

ZECTBynmo commented 9 years ago

You are now my favorite person @zhangyuanwei :)

I'll take a look trough this and merge it in ASAP. Thanks a ton for the work

ZECTBynmo commented 9 years ago

Thanks again for doing this work!

It's not clear to me why yet, but there's something wrong with the module after your change (and maybe before? not sure...)

If you run the sample app in the examples directory, you can probably hear the audio dropping out. I'm very low on time (as evidenced by how long it took for me to respond), but I might be able to check it out at some point.

ZECTBynmo commented 9 years ago

Actually I had setup a bad audio configuration, and I believe things are working. :+1: