search

AudioNet / node-core-audio

Bindings for PortAudio giving JavaScript access to sound card samples (mostly unmaintained)
MIT License
330 stars 68 forks source link

Fixing installation for node v4.2.1 #50

Closed vsukhomlinov closed 8 years ago

vsukhomlinov commented 8 years ago

Upgrading Nan to latest so that package can be installed on node 4.2.1(LTS) Fixes #48, #49

Any suggestions on how to write a test that covers most of logic?

vsukhomlinov commented 8 years ago

Hey @ZECTBynmo, just wandering, are you still maintaining this project?

ZECTBynmo commented 8 years ago

@vsukhomlinov Thanks for the pull request. I'm theoretically still maintaining the project, but I have a lot of real world stuff going on right now, so I'm doubly appreciative of the help.

I'll hopefully get a chance to look over this PR this week some time and push out an npm update, but I can't promise anything. If someone else (maybe one of the creators of the issues you mentioned) comes in here and vouches for the patch, I'll accept it on faith :)

mzgoddard commented 8 years ago

I'm not one of the issue creators but I can state that it builds on my main machine and works on Node 4.2.1 on Mac OS X El Capitan.

ZECTBynmo commented 8 years ago

Thanks @vsukhomlinov and @mzgoddard. Sorry for my slow progress