Audionut / Upload-Assistant

A fork of L4G attempting to keep updated
https://discord.gg/QHHAZu7e2A
69 stars 23 forks source link

Overhall/refactor HTTP/API upload handling #34

Closed Audionut closed 2 months ago

Audionut commented 2 months ago

I can see scope for all of this handling to be improved. For instance HDB was allowed to HTTP rather than rely only on their API (better for the site), but that meant that the validate_credentials check in the HTTP upload handling is missed, even though that HDB specific validate_credentials function has API checking.

All of the API sites should have their responses checked.

Updating other UNIT3D sites to handle mod_q, in it's current state, is going to increase the code through mere duplication. This should be handled gracefully within the existing API handling, with minimal code increase instead.