search

AudiusProject / audius-protocol

The Audius Protocol - Freedom to share, monetize, and listen to any audio content.
https://docs.audius.org
Other
552 stars 106 forks source link

core: cleanup sandboxes #9946

Closed alecsavvy closed 9 hours ago

alecsavvy commented 1 day ago

Description

How Has This Been Tested?

make sandbox-hosts (just once) make sandbox navigate to http://prod-sandbox/console and you'll see your node syncing blocks

changeset-bot[bot] commented 1 day ago

⚠️ No Changeset found

Latest commit: 02cabc30978c04ddeff2b6db9a4e6464c15429d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gitguardian[bot] commented 1 day ago

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [9412812](https://dashboard.gitguardian.com/workspace/27667/incidents/9412812?occurrence=166827036) | Triggered | Generic Password | f8ce1e8c8538010f0632adb7bee938fe4b935107 | core/infra/docker-compose.yml | [View secret](https://github.com/AudiusProject/audius-protocol/commit/f8ce1e8c8538010f0632adb7bee938fe4b935107#diff-354973a20c42e19ab811f567579a907f8a65c235fc922bfbd3a365e1fc981c0dL53) | | [11648676](https://dashboard.gitguardian.com/workspace/27667/incidents/11648676?occurrence=166827035) | Triggered | Generic High Entropy Secret | 7d9353ff1467675eeb99372a0d379103db0ab85e | core/infra/dev_config/sandbox-one.env | [View secret](https://github.com/AudiusProject/audius-protocol/commit/7d9353ff1467675eeb99372a0d379103db0ab85e#diff-c614183499e073124bfbebffea189db90334ad35efefe869390a5d716aede0baL2) | | [11648676](https://dashboard.gitguardian.com/workspace/27667/incidents/11648676?occurrence=166827037) | Triggered | Generic High Entropy Secret | f8ce1e8c8538010f0632adb7bee938fe4b935107 | core/infra/dev_config/stage-sandbox.env | [View secret](https://github.com/AudiusProject/audius-protocol/commit/f8ce1e8c8538010f0632adb7bee938fe4b935107#diff-9e9721d8595450b5b2bc43db8a908275fd9f81d47edd49b41303246fb8f95909R2) | | [11648676](https://dashboard.gitguardian.com/workspace/27667/incidents/11648676?occurrence=166827038) | Triggered | Generic High Entropy Secret | f8ce1e8c8538010f0632adb7bee938fe4b935107 | core/infra/dev_config/prod-sandbox.env | [View secret](https://github.com/AudiusProject/audius-protocol/commit/f8ce1e8c8538010f0632adb7bee938fe4b935107#diff-1fa06dcb295add584f9f350ff596daacc2fe8bf6c7180d264bcb4abc12211f50L2) | | [11648676](https://dashboard.gitguardian.com/workspace/27667/incidents/11648676?occurrence=166827039) | Triggered | Generic High Entropy Secret | f8ce1e8c8538010f0632adb7bee938fe4b935107 | core/infra/dev_config/dev-sandbox.env | [View secret](https://github.com/AudiusProject/audius-protocol/commit/f8ce1e8c8538010f0632adb7bee938fe4b935107#diff-2ff4375925165ff8bec996f4c65214bd6a7a94df4cf0e400ddd95d34a0761330R2) | | [11648676](https://dashboard.gitguardian.com/workspace/27667/incidents/11648676?occurrence=166827040) | Triggered | Generic High Entropy Secret | 341ccc1f00aaa26b1358382bf7b690cae125e998 | core/infra/dev_config/prod-sandbox.env | [View secret](https://github.com/AudiusProject/audius-protocol/commit/341ccc1f00aaa26b1358382bf7b690cae125e998#diff-1fa06dcb295add584f9f350ff596daacc2fe8bf6c7180d264bcb4abc12211f50R2) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.