Closed hbitteur closed 6 years ago
Is this the kind of output we want after resolving this issue? :)
@nasehim7 Perhaps I don't really understand your question
My position is that reference data should cover as much configurations as possible. This include the repeat signs. In this example, there are 2 repeat signs, one left and one right. For each of them, try to provide the outer compound (such as left repeat sign) and its inner members (thick barline, thin barline, top repeat dot, bottom repeat dot). Sorry, I'm writing this away from my computer, I don't have the exact symbol names at hand.
@hbitteur No problem, I got it. We want a nested approach in this one too. Working on it, currently, I'm done with getting the outer element which can be seen in the above control image. Will get back soon. :)
I did the nesting part. For Reference, Below are the control images:
Hope it is in sync with what we want for the OMR. @hbitteur @lasconic
This looks OK, thanks
@hbitteur what exactly are the names of these thick and thin barlines? :)
You can use the SMuFL names : http://www.smufl.org/version/latest/range/barlines/
@hbitteur @lasconic I think now the implementation is more refined than the previous one. Below are the control images:
I have added the commit to the existing PR. Hope it suits well. :)
@lasconic Should we close this too? It will be good in the next dataset. :)
We need examples for all the various meanings of dots.