No example for Staccato dot at all

Audiveris / omr-dataset-tools

Reference of OMR data

GNU Affero General Public License v3.0

18 stars 5 forks source link

No example for Staccato dot at all #25

Closed hbitteur closed 6 years ago

hbitteur commented 7 years ago

I didn't find any staccato dot in the .xml files. Are they not correctly addressed by the export software? Or simply, these symbols don't show up in any sheet you exported?

nasehim7 commented 6 years ago

Hi @hbitteur I tried reconstructing the issue. I placed a staccato below and Staccatissimo above in a score. After that when I generated the XML, I got :

<Symbol interline="20" shape="Staccatissimo stroke above">
    <Bounds x="143.882" y="60.864" w="0.626" h="3.781"/>
    </Symbol>
  <Symbol interline="20" shape="Staccato below">
    <Bounds x="240.822" y="271.280" w="3.984" h="3.984"/>
    </Symbol>

in the file. I made no implementation changes. Let's discuss on what I am missing here or is it working fine? :)

lasconic commented 6 years ago

I guess shape should contain a SMuFL id instead of an english string ?

nasehim7 commented 6 years ago

The implementation converts Id to string like const Articulation* a = toArticulation(e); SymId symId = a->symId(); QString symName = Sym::id2userName(symId); writeData(xml, mag, a->mag(), symName, a); The symbol name is sent to the function which writes it in the XML file. The implementation is same for some of the element types like Articulation, Clef etc. in the edata.cpp.

lasconic commented 6 years ago

id2userName should be id2name

nasehim7 commented 6 years ago

Okay making the changes for all other element types accordingly. :)

nasehim7 commented 6 years ago

Staccatos are fine. Will be available in the next dataset. For reference, below are the control images: