search

Audiveris / omr-dataset-tools

Reference of OMR data
GNU Affero General Public License v3.0
18 stars 5 forks source link

Acciaccatura and appoggiatura annotations missing #27

Open hbitteur opened 7 years ago

hbitteur commented 7 years ago

Could we get annotations for graceNoteAcciaccaturaStemUp (slashed) and graceNoteAppoggiaturaStemUp (no slash)? The best approach would be to have them as whole symbols, with their components (head, stem, slash?) as nested symbols. If this is too complex, simply provide the whole symbols.

nasehim7 commented 6 years ago

Hi @hbitteur It will be good if we can get a test example for the above, like how exactly should the XML look :)

nasehim7 commented 6 years ago

Hi @hbitteur and @lasconic, I have worked on making the GraceNotes better. I have taken the nested approach as was required for this issue. Here are some control Images for the same: -

screen shot 2018-06-22 at 9 49 44 pm screen shot 2018-06-22 at 9 49 53 pm screen shot 2018-06-22 at 9 50 00 pm screen shot 2018-06-22 at 9 50 14 pm

Would love your comments on this :)

hbitteur commented 6 years ago

These items look OK for me. I don't know if Audiveris will actually use all these tiny items, but thanks to the "nesting approach" we have the ability to pick up whatever granularity we want to work with. Thanks.

nasehim7 commented 6 years ago

Thanks, Herve and lasconic for the review. Yes, surely nesting approach is good for us. We want the best for this project. :) Hope you have a great weekend :D