Audiveris / omr-dataset-tools

Reference of OMR data
GNU Affero General Public License v3.0
18 stars 5 forks source link

Image format using 256 levels of gray #31

Open hbitteur opened 7 years ago

hbitteur commented 7 years ago

Could we get gray images (256 gray values on 1 byte) rather than the ARGB color model on 4 bytes.

nasehim7 commented 6 years ago

Here we are basically talking about saving the png's in Format_GrayScale8 if we have our OMR flag set and not save in ARGB32_Premultiplied. It can be possible with the master using convertToFormat() method of QImage but for MuseScore versions which use Qt version below 5.5, this simple conversion can't be possible. I have done this change for master in my current branch nasehim7/timeSigBranch and we have an active PR: https://github.com/musescore/MuseScore/pull/3669.

Incase, there is anything that I am missing, Kindly let me know :)

hbitteur commented 6 years ago

Sorry, I'm not familiar with these C++ names. The target format (in Java) would be BufferedImage.TYPE_BYTE_GRAY (an unsigned byte grayscale image, non-indexed). So the word "GrayScale8" sounds (but only sounds) OK to me. That's all I can say.

nasehim7 commented 6 years ago

Yes Herve I have checked it. Hopefully it will be a fit for tackling our issue. If not, we will see, what else we can go ahead with. Not an issue. :D On Tue, 26 Jun 2018 at 9:35 PM, Hervé Bitteur notifications@github.com wrote:

Sorry, I'm not familiar with these C++ names. The target format (in Java) would be BufferedImage.TYPE_BYTE_GRAY (an unsigned byte grayscale image, non-indexed). So the word "GrayScale8" sounds (but only sounds) OK to me. That's all I can say.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Audiveris/omr-dataset-tools/issues/31#issuecomment-400368044, or mute the thread https://github.com/notifications/unsubscribe-auth/ARM0RuWa9LbnpQSKrf-FgShp8F3CnI5hks5uAlvCgaJpZM4PjEJB .