search

AudreyFelicio / pe

0 stars 0 forks source link

Cannot Re-Add SU-ed Failing Modules in Other Semesters #2

Open AudreyFelicio opened 3 years ago

AudreyFelicio commented 3 years ago

As far as I remember, if you SU a module with grade below C, then you will get a Unsatisfactory (U) grade and you have to take the module again in the future.

Consider the case that I failed MA1100 in Y1S1 with grade F, and I SU-ed it and I want to retake the module again during Y1S2. I cannot add the module to Y1S2 without deleting the history that I have taken the module before on Y1S1.

Steps to reproduce:

  1. Enter start y1s1.
  2. Enter add m/MA1100 g/F.

image.png

  1. Enter su MA1100.

image.png

  1. Enter start y1s2.
  2. Enter add m/MA1100 g/A.

image.png

nus-se-bot commented 3 years ago

Team's Response

This is rejected as this is a design consideration from our team to be consistent with the way NUS accounts for re-taken modules.

This is as per NUS's system, if you SU'd a failed module, and re-took the module again in another semester, only the graded re-taken module would be taken into consideration for the calculation of CAP and ultimately the user's results.

Therefore, to prevent confusion to users, we ensured that users are unable to add duplicated modules, so that users will not be able to accidentally count the same module twice.

The user would thus need to delete the failed module, and re-add the graded module, which is the ONLY module that NUS would consider in the user's results, and is thus consistent with NUS's system.

Hence, this is rejected as this behaviour is expected and intended.

Severity is changed to low as this would not affect most users who get at least a pass, thus only occurs in rare situations, and in the event that they do fail the module and need to retake the module, the functionality of the app would not be affected as the CAP calculation for the user would still be accurate as the app would only take into consideration the grade of the ONE graded module that the user ultimately inputs.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response.

This is as per NUS’s system, if you SU’d a failed module, and re-took the module again in another semester, only the graded re-taken module would be taken into consideration for the calculation of CAP and ultimately the user’s results.

I agree that only the graded re-taken module that is considered for the calculation of CAP, but the history that you have taken the module before retaking it still persists in your education record. Therefore, it would be correct that the history that you SU-ed a mod should still persists in the list and the app should allow re-adding failing modules without deleting the history. Hence, this is a valid feature flaw.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]