AudreyFelicio / pe

0 stars 0 forks source link

Incorrect Error Message For Delete Command and Format Not Consistent With Other Commands #3

Open AudreyFelicio opened 3 years ago

AudreyFelicio commented 3 years ago

Invalid command format error message for delete is never shown. Example command usage, brief command description, and valid command format is never shown. Other commands such as add and update have the above descriptions if the command format is invalid. In short, the error message format displayed is not consistent with other commands.

Steps to reproduce:

  1. Enter 'delete'

image.png

nus-se-bot commented 3 years ago

Team's Response

It is not a compulsory requirement to ensure that the format of all the error messages is consistent throughout all the commands. It is a nice-to-have implementation, but not a must-have. The tester classifies this as a functionality bug which is wrong as it does not affect the functionality of the 'delete' command in any way at all and is NOT essential for our app to be reasonably useful. Thus it is not considered a bug as it is only a good-to-have.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response.

It is correct that this is classified as a functionality bug as behavior of the error message for delete differs from normal expectations.

As a user, seeing that the other commands if the format is invalid, will show Invalid command format! as the header along with example command usage, brief command description, and valid command format, I will expect that all invalid commands error message will have that format. This is in fact not the case for your delete command.

image.png