search

AudreyFelicio / pe

0 stars 0 forks source link

Command Format Inconsistent #6

Open AudreyFelicio opened 3 years ago

AudreyFelicio commented 3 years ago

Commands that use the same parameters has different format for the parameters.

For example, in start SEMESTER, the parameter SEMESTER does not have the prefix s/, but in update m/MODULE_CODE [g/GRADE] [s/SEMESTER], the parameter SEMESTER has the prefix s/.

Same issue for the parameter MODULE_CODE.

It would be more convenient for users to remember the commands if their parameter formats are consistent.

nus-se-bot commented 3 years ago

Team's Response

Hi. Firstly, since the command 'su' and 'delete' will only require one parameter, which is the module code, it is unnecessary to include a prefix, i.e. 'm/', which is to uniquely identify the parameters (as opposed to, eg 'add' command which can have more than one parameter, and hence requires the use of prefixes to distinguish one parameter from another). This was a design consideration as we want to optimise the software for "fast typist" - a requirement stated for tp. This was intended.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]