search

AudunVN / Navmap

Browser-based system map viewer for the Freelancer mod Discovery.
http://space.discoverygc.com/navmap
7 stars 8 forks source link

GitHub Pages-hosted version does not work. #1

Closed AudunVN closed 8 years ago

AudunVN commented 8 years ago

jQuery stops with three "Too much recursion errors" which I've never seen before; investigate. Non-critical, though, as this is mostly meant to be used as a code repo for version control, not a hosting solution. Would be nice to know why it stops working, though...

AudunVN commented 8 years ago

I strongly suspect that this is an issue with the loading of infocards.txt from GitHub Pages.

AudunVN commented 8 years ago

The issue is very clearly with parsing infocards.txt - the file seems to load correctly, but the script is unable to parse it - resulting in it happily finishing the $.get request with an undefined infocardArray - which suggests something's odd with the encoding as it is host-dependent.

AudunVN commented 8 years ago

Wow; commit d24c6cf50ca622f9f139baa0e746bf230a902461 fixed that, but it still has issues with parsing \r\n in other places. Lesson learned: Bring your old messy regex up to spec and stop explicitly looking for \r\n as a line separator, looks like there are more than a few cases where that can break during the server-client transfer.

AudunVN commented 8 years ago

Issue closed by commit 7efd7dd0808f9a657661e626dc06af79d4bc020e. Probably not ever going to be an issue on the live version, but it's nice to know that it won't happen again if the encoding/compression/whatever changes overnight over at Discovery.