fixing errors on new loan page

Augmint / augmint-web

Augmint Web Frontend

http://www.augmint.org

GNU Affero General Public License v3.0

17 stars 8 forks source link

fixing errors on new loan page #572

Closed rszaloki closed 5 years ago

rszaloki commented 5 years ago

Nature of the PR: bug/feature/chore

Steps to reproduce:

Trello card / screenshot / wireframe link:

Is connection necessary to test? If so which network?

[ ] local RPC
[ ] Rinkeby
[ ] Main Ethereum Network

szerintedmi commented 5 years ago

Deploy preview for augmint ready!

Built with commit 5f1aed21e32dfe8118ddf90d5ca6968e43ce5424

https://deploy-preview-572--augmint.netlify.com

rszaloki commented 5 years ago

Yeah, thats another problem with the webserver's config: it cannot comprehend urls with two slashes :( eg: /loan/new or /lock/new)

szerintedmi commented 5 years ago

Yeah, thats another problem with the webserver's config: it cannot comprehend urls with two slashes :( eg: /loan/new or /lock/new)

It used to be working. Something has changed somewhere.

szerintedmi commented 5 years ago

Yeah, thats another problem with the webserver's config: it cannot comprehend urls with two slashes :( eg: /loan/new or /lock/new)

It used to be working. Something has changed somewhere.

it seems to be an unrelated issue, /account works, /account/ doesn't on deployment.

rszaloki commented 5 years ago

Hmm, strange :( I can't find any errors before this commit. There were two errors:

React complained about key collision on the list items (this is fixed with the key={product.id}
React also complained about the for attribute

However, today I checked the staging before this branch and I can't reproduce it either. Should I close it?

szerintedmi commented 5 years ago

@rszaloki : shall we merge or close this ? I already approved but you suggest we should just close