Augmint / augmint-web

Augmint Web Frontend
http://www.augmint.org
GNU Affero General Public License v3.0
17 stars 8 forks source link

Margin loan #697

Closed rszaloki closed 5 years ago

rszaloki commented 5 years ago

WIP!

szerintedmi commented 5 years ago

Deploy preview for augmint ready!

Built with commit 52dc18bb475eff4007dd8f014b9cf36fcdb740fb

https://deploy-preview-697--augmint.netlify.com

szerintedmi commented 5 years ago

I would review it but build failed:

error Couldn't find any versions for "@augmint/js" that matches "0.3.4"
szerintedmi commented 5 years ago

when / why did it became red despite it's far from due? image

szerintedmi commented 5 years ago

some collateralisation info should be added. Maybe % ? And a big warning if it's below a threshold? (that warning should go to my account page too?) @krosza ? @phraktle ? image

phraktle commented 5 years ago

some collateralisation info should be added. Maybe % ? And a big warning if it's below a threshold? (that warning should go to my account page too?)

Yes, discussed this today, we’ll add a large box with collateralization level (and margin call rate) that turns red with a warning (similar to due date).

szerintedmi commented 5 years ago

stability report on mainnet, legacy loans sum seems to be wrong (unfortunately :) ). image

krosza commented 5 years ago

collateralisation and rate info to be included: ( besides collateralization level!)

Q: there will not be partial repayment? Q: what is the purpose of MARGIN LOAN button?

On Mon, 29 Jul 2019 at 20:54, Peter Petrovics notifications@github.com wrote:

some collateralisation info should be added. Maybe % ? And a big warning if it's below a threshold? (that warning should go to my account page too?) @krosza https://github.com/krosza ? @phraktle https://github.com/phraktle ? [image: image] https://user-images.githubusercontent.com/7456451/62074392-98a04b80-b23a-11e9-9ceb-2b70d6f08c5c.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Augmint/augmint-web/pull/697?email_source=notifications&email_token=ADBULAW332KMW5QN5PAO7QDQB44IDA5CNFSM4IGEBGZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3BVN5Q#issuecomment-516118262, or mute the thread https://github.com/notifications/unsubscribe-auth/ADBULAVMZQVMJJBAXKSUK2LQB44IDANCNFSM4IGEBGZA .

krosza commented 5 years ago

Stability Report has some serious issue:

It does not reveal the real solvency of Augmint. the problem that after collection if there was no immediate aeur buy of the collected loan amount the system quickly can became insolvent. This is the case now, because the actual eth rate lower than the collection eth rate was. Ergo there is no enough eth in the market intervention reserve to buy the appropriate amount of aeur. Even worse that it is quite complicated to figure out the actual missig eth amount. or the aeur supply without cover.

The uncovered aeur amount = Loans Collected- A-EUR Market Intervention Reserve - ETH Market Intervention Reserve*actual eth rate if it is a negative amount, that means profit to be realized.

On Mon, 29 Jul 2019 at 20:59, Peter Petrovics notifications@github.com wrote:

stability report on mainnet, legacy loans sum seems to be wrong (unfortunately :) ). [image: image] https://user-images.githubusercontent.com/7456451/62074740-4d3a6d00-b23b-11e9-8966-1bce4a262055.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Augmint/augmint-web/pull/697?email_source=notifications&email_token=ADBULARWDK3YUQCZ75MTTOLQB442FA5CNFSM4IGEBGZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3BV2NA#issuecomment-516119860, or mute the thread https://github.com/notifications/unsubscribe-auth/ADBULASPDWD7SOF4CFVQBQLQB442FANCNFSM4IGEBGZA .

phraktle commented 5 years ago

@szerintedmi @krosza Stability Report bug was fixed. For other issues related to Stability Report, please open a separate ticket since it's not related to margin loans.

Loan card was updated as follows.

Normal state:

Screen Shot 2019-08-02 at 17 22 50

Margin call warning state:

Screen Shot 2019-08-02 at 17 23 26