search

AugurProject / augur-app

Augur Desktop Electron Application
MIT License
222 stars 22 forks source link

make the merge for config actually merge #394

Closed nuevoalex closed 6 years ago

nuevoalex commented 6 years ago

merge function params were reversed.

Also just made it always merge in since its quick and reduces code and possible weird failure cases in the future

nuevoalex commented 6 years ago

I don't think that is what we want. The provided default should override whatever the user's config had previously since this is the part of the config we control and define which the user does not modify.

If we update the mainnet config we want our updated version to overwrite whatever they have on disk. The custom configs they have will still persist since there is nothing in our default to overwrite them.

bthaile commented 6 years ago

Good point, like if we change existing endpoints. Gotcha