Improve top-level error handling in ethrpc

AugurProject / augur-app

Augur Desktop Electron Application

MIT License

222 stars 22 forks source link

Improve top-level error handling in ethrpc #417

Closed adrake33 closed 5 years ago

adrake33 commented 5 years ago

chwy was seeing the following error while running the Augur App on Rinkeby:

12-10

We should make this and other top-level errors into warnings. We also need a less fragmented strategy for error handling/logging that works well across desktop & mobile.

JohnDanz commented 5 years ago

these errors are coming from ethrpc, specifically this file: https://github.com/ethereumjs/ethrpc/blob/master/src/block-management/start-polling-for-blocks.js

Do we want to make these warnings? It seems like error is more appropriate.

bthaile commented 5 years ago

@pgebheim closing.