search

AugurProject / augur-app

Augur Desktop Electron Application
MIT License
222 stars 22 forks source link

Back button in UI doesn't always go back to correct page #426

Open adrake33 opened 5 years ago

adrake33 commented 5 years ago

Summary

The Back button on the trading page does not go back to the correct place on the Portfolio page.

Steps to reproduce

  1. Sign into dev.augur.net with test account 0x913dA4198E6bE1D5f5E4a40D0667f70C0B5430Eb.
  2. Scroll down to the Resolved section of the Portfolio:Positions page and go to the second page of markets.
  3. Click on a market, such as "test scalar 8-1"

  4. When the trading page comes up, click on the Back button and note that it returns to the top of the Portfolio:Positions page, not the Resolved section.

    Expected behavior

    Ideally, the Back button should return to same place on the Portfolio:Positions page. This can be confusing to users.

adrake33 commented 5 years ago

This will likely be resolved by the new trading page redesign, leaving it open for now

pgebheim commented 5 years ago

@bthaile @adrake33 --- Will this actually be taken care of in this new Trading page redesign? If not I think we should just move this into the Bugs epic and decide a priority.

bthaile commented 5 years ago

It will be less obvious in the redesign. This is an issue of how we handle navigation history and our back buttons.

We do a makeshift version of “back” with users going from trading page to report/dispute and send the user back to trading page, buts a hack.

We need to design for this behavior when building out the redesign.

JohnDanz commented 5 years ago

so i just tested this with the new design and it seems to go back to the right spot (as mentioned above, because of the redesign this seems to be resolved).

JohnDanz commented 5 years ago

so i just tested this with the new design and it seems to go back to the right spot (as mentioned above, because of the redesign this seems to be resolved).

bthaile commented 5 years ago

moving to design review for testing

pgebheim commented 5 years ago

@bthaile @JohnDanz -- Joey tested and things are still wonky.

Will probably need to look at all the navigation before launch and make sure things are sane.