Shutdown subsystems (and geth) on electron 'will-quit' event

AugurProject / augur-app

Augur Desktop Electron Application

MIT License

222 stars 22 forks source link

Shutdown subsystems (and geth) on electron 'will-quit' event #449

Closed ryanberckmans closed 5 years ago

ryanberckmans commented 5 years ago

Fixes AugurProject/augur#261

I was also able to cause geth to quit without properly cleaning up the UDP listener socket used for p2p discovery. For this I opened a new issue https://github.com/ethereum/go-ethereum/issues/18443.

ryanberckmans commented 5 years ago

@pgebheim you're right, looks like we could handle the shutdown more cleanly in terms of blocking/non-blocking behavior. (At least the Promise returned by augurNodeController.shutdown().) Propose we add a new issue for that problem and merge this PR.

pgebheim commented 5 years ago

Ok I'm down with that!

Merged.