Described in discord as well but to note here for posterity in GH:
When we recalculate the various market creation bonds we do so by looking at the results of markets assigned to the previous fee window. We cannot know (record really) this data until the markets have been finalized however. This means that if we simply look at the direct previous fee window to get this data there is an opportunity to simply create a market before any of the previous windows markets have finalized, thereby locking in decreased bond sizes regardless of how the markets actually resolved (valid, with DR input, with correct initial report).
To address this problem the change in this PR simply makes the calculations look at the window before the previous fee window. This gives a 7 day window for markets to be finalized before calculating bond changes.
Described in discord as well but to note here for posterity in GH:
When we recalculate the various market creation bonds we do so by looking at the results of markets assigned to the previous fee window. We cannot know (record really) this data until the markets have been finalized however. This means that if we simply look at the direct previous fee window to get this data there is an opportunity to simply create a market before any of the previous windows markets have finalized, thereby locking in decreased bond sizes regardless of how the markets actually resolved (valid, with DR input, with correct initial report).
To address this problem the change in this PR simply makes the calculations look at the window before the previous fee window. This gives a 7 day window for markets to be finalized before calculating bond changes.