Some possible inconsistency in Map.sol

[wlamos]

For a map data structure, it should satisfy:

for every (key, value), if _add(key, value)_ returns true, we should have _contains(key)_ return true.

 But in this implementation, if value is 0, the above property is not satisfied. 

[nuevoalex]

@wlamos That's fair. You're suggesting we add a require(_value != bytes32(0)) in the add method, right?

[wlamos]

Yes.

[adrake33]

Added ClubHouse ticket for this: https://app.clubhouse.io/augur/story/16250/add-require-statement-to-map-add-for-consistency

[adrake33]

Closing, as this has been added to v2 of the contracts.