search

AugurProject / augur-core

Augur v1 - Smart Contracts [DEPRECATED]
https://www.augur.net
GNU General Public License v3.0
595 stars 133 forks source link

switch to using the optimized proxy contract instead of our delegator #756

Closed nuevoalex closed 5 years ago

nuevoalex commented 5 years ago

Using the minimal proxy contract instead of our Delegator: https://github.com/optionality/clone-factory/issues/10

Gas savings of roughly 25-40% on everything!

codeclimate[bot] commented 5 years ago

Code Climate has analyzed commit 930b938c and detected 14 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Duplication 11

View more on Code Climate.

epheph commented 5 years ago

So this look great, and it will save a ton of gas, both in a more optimal delegator AND in no more controller lookups.

Like @MicahZoltu , I am just a tiny bit spooked about the setController defaulting to 0, but see why this is required now with the new clone method. It helps that that modifier is ONLY called when setting controller, and a controller left at 0 should be very noticeable (since lookups stop working) it shouldn't be able to pass tests easily.