search

AugurProject / augur-ui

Augur UI
https://dev.augur.net
MIT License
399 stars 100 forks source link

Removes Website wording in resolution source during market creation. #3129

Closed MicahZoltu closed 5 years ago

codeclimate[bot] commented 5 years ago

Code Climate has analyzed commit fab23a67 and detected 0 issues on this pull request.

View more on Code Climate.

MicahZoltu commented 5 years ago

Pretty sure this will break tests, but wanted to get the proposal out there and started. Someone who actually knows what they are doing, feel free to take this over. :)

MicahZoltu commented 5 years ago

Why didn't this fail? https://github.com/AugurProject/augur-ui/blob/master/integration/create-market.test.ts#L158 Are tests not run as part of CI?

bthaile commented 5 years ago

I think there is a market creation test that needs to be updated. And look, there might be another instance of that phrase in the market creation code.

nuevoalex commented 5 years ago

I don't think we have any tests that just check if all copy is what we set it to. In general any test I'd want a script to update for me isn't very useful

pgebheim commented 5 years ago

Those tests (the integration ones) don't run in CI because they're so flakey.