AugurProject / augur

Augur v2 - Prediction Market Protocol and Client
MIT License
453 stars 143 forks source link

Architect gas handling for TypeChain and L1/L2 #10802

Closed robert-e-davidson3 closed 2 years ago

robert-e-davidson3 commented 3 years ago

Our current gas estimation and pricing strategy is a bit of a kludge. We had to work around a third party bug and meet a deadline. It also doesn't quite seem to work right for Arbitrum. On the robert/arbitrum branch, I use TypeChain instead of our custom contract api solution. This makes gas overrides easy but lacks some of the features we need.

We need to manage state for all contract calls on a particular chain:

This will affect flash as well as the middleware.

pgebheim commented 3 years ago

Can we talk to offchain labs about this gas must be === 0 for calls situation?

robert-e-davidson3 commented 3 years ago

Can we talk to offchain labs about this gas must be === 0 for calls situation?

Good idea. It seems like a bug since they should just ignore that value completely for calls.

robert-e-davidson3 commented 2 years ago

The solution here is to switch to industry standard (hardhat etc) since the industry standard now works.