AugurProject / augur

Augur v2 - Prediction Market Protocol and Client
MIT License
459 stars 143 forks source link

Sports Betting - My Account - Page Layout Responsive #7403

Closed yanelbottini closed 4 years ago

yanelbottini commented 4 years ago

Mobile layout:

Figma link

Responsive references:

Figma link

JohnDanz commented 4 years ago

https://github.com/AugurProject/augur/issues/8873

yanelbottini commented 4 years ago

In general looks fine. Some comments:

Screen Shot 2020-09-16 at 09 56 05

WhatsApp Image 2020-09-16 at 10 00 35 (2)

Screen Shot 2020-09-16 at 10 09 39 Screen Shot 2020-09-16 at 10 13 24 Screen Shot 2020-09-16 at 10 16 56 Screen Shot 2020-09-16 at 10 17 13 Screen Shot 2020-09-16 at 10 16 04

Figma reference: https://www.figma.com/file/wogMuUDylgOHgTEYhZ3jgp/Augur-Bet-UI?node-id=4153%3A196592

yanelbottini commented 4 years ago
bconfortin commented 4 years ago

@yanelbottini

Missing Apply filter button.

When I created those filters, I made them generic so we could use the same component anywhere in the UI. Since it's generic, it's hard to keep track of which filters were applied, that's why the filters are applying automatically when clicked instead of when we click an "Apply filters" button.

I still need to figure out the best strategy for that, so I am going to ask you create a separate ticket since it's going to demand some work.

Or we can leave it without the button since the filter process in this case is very fast and performant, as opposed to the Market List page, where we fetch a lot of data every time we click the "Apply filters" button.

yanelbottini commented 4 years ago

Hi @bconfortin Ok. I'll check with Chwy and Matt to see what they think.

I've found some other stuff on mobile:

WhatsApp Image 2020-10-14 at 06 18 42 (5)

WhatsApp Image 2020-10-14 at 06 18 42

yanelbottini commented 4 years ago

Looks fine. Wonder if we can unify the style for this 2 empty states. One has a box, while the other doesn't. Let's do whatever is simpler, but double check that all the sections within My Account (Favorites, Active Markets, Created Markets, Favs, Notifications) use the same pattern:

e118d2e3-b4dc-417b-a0e1-551b85e2521f

fff38225-5f60-4c24-9567-3a1322478e02

Can we delete the line break between "Only... To view" so it fits in 3 lines?

Screen Shot 2020-10-16 at 10 59 20