Closed yanelbottini closed 4 years ago
In general looks fine. Some comments:
Figma reference: https://www.figma.com/file/wogMuUDylgOHgTEYhZ3jgp/Augur-Bet-UI?node-id=4153%3A196592
Dropdown styles are incorrect. The ones applied to My created markets are ok.
Missing buttons:
Footer should be fixed to bottom:
Gray bkg should continue. Missing Apply filter button.
@yanelbottini
Missing Apply filter button.
When I created those filters, I made them generic so we could use the same component anywhere in the UI. Since it's generic, it's hard to keep track of which filters were applied, that's why the filters are applying automatically when clicked instead of when we click an "Apply filters" button.
I still need to figure out the best strategy for that, so I am going to ask you create a separate ticket since it's going to demand some work.
Or we can leave it without the button since the filter process in this case is very fast and performant, as opposed to the Market List page, where we fetch a lot of data every time we click the "Apply filters" button.
Hi @bconfortin Ok. I'll check with Chwy and Matt to see what they think.
I've found some other stuff on mobile:
Looks fine. Wonder if we can unify the style for this 2 empty states. One has a box, while the other doesn't. Let's do whatever is simpler, but double check that all the sections within My Account (Favorites, Active Markets, Created Markets, Favs, Notifications) use the same pattern:
Can we delete the line break between "Only... To view" so it fits in 3 lines?
Mobile layout:
Figma link
Responsive references:
Figma link