AugurProject / augur

Augur v2 - Prediction Market Protocol and Client
MIT License
463 stars 143 forks source link

Portis Not working for signup on mobile #7478

Closed Chwy5 closed 4 years ago

Chwy5 commented 4 years ago

On Mobile - try signing up for a new account on Portis after submitting it takes user right back to the portis signup screen (no act gets created)

andrewdamelio commented 4 years ago

@chwy tested on iPhone + safari and it worked fine.

What device/browser are you having issues with?

Chwy5 commented 4 years ago

Joey and tom on iphone safari and I am on chrome on Galaxy s10

pgebheim commented 4 years ago

@andrewdamelio -- Do you have cookie / popup blocking already excluded for the v2.augur.net domain by chance? Worth checking --- @bthaile is on iOS 13.4.1 in safari and is getting a login loop when attempting to login with Portis.

andrewdamelio commented 4 years ago

I do not! let me try updating to 13.4.1

andrewdamelio commented 4 years ago

@Chwy5 @pgebheim I updated to 13.4.1 and don't see the issue.

@bthaile do you remember, are you clicking Allow or Disallow for email display on Portis signup?

andrewdamelio commented 4 years ago

@Chwy5 @pgebheim @bthaile

Ok i think figured out whats going on here. It seems like the second Portis modal (Allow/Disallow) gets blocked by the market list loading - it waits until Syncing Complete - SDK Ready

So if you create a Portis account and syncing is still happening after you finish you will get stuck here until Sync is finished.

Once Sync is complete, you should see the next steps

Since on mobile safari syncing sometimes takes forever this issue appears more so there than on desktop.

In terms of a fix, i'm not sure what the right UX is, especially with the limitation of he Portis iframe not being under our control.

Easy fix could be to disable (only) the signup button, until Augur is fully loaded to avoid getting the permissions window blocked.

pgebheim commented 4 years ago

Is there a reason we need to wait for syncing to complete to continue?

andrewdamelio commented 4 years ago

@pgebheim FYI i took a look at this yesterday, looks like we don't have the issue with Fortmatic/Torus so it isn't related to what i was thinking above..

Going to look into the Portis flow today to see if what could be block / waiting on SDK there.

pgebheim commented 4 years ago

@andrewdamelio Status on this?

andrewdamelio commented 4 years ago

ready to be tested again -- working for me now after some of the onboarding fixes

matt-bullock commented 4 years ago

Working for me. Closing