AugurProject / augur

Augur v2 - Prediction Market Protocol and Client
MIT License
463 stars 143 forks source link

Change global chat to Orbit #7500

Closed Chwy5 closed 4 years ago

Chwy5 commented 4 years ago

Torus takes 3 signings and portis takes 2 signings......This needs to get down to 1 signing

Also the speed of loading takes forever....a good 1 minute after I hit the load chat button

pgebheim commented 4 years ago

Removing bug label because this isn't a bug, the signings are as designed by 3box and there's nothing we can really do about that approach.

As for speed, the probably solution is to try to load it a little earlier so that the ipfs connections can be all warmed up. Ideally this would be an optimization that we do at some point that shares the same ipfs instance between 3box and the warp sync client.

@bconfortin Can you add your notes here?

bconfortin commented 4 years ago

@pgebheim We might be able to solve the number of signings. 3box released something they are calling 3ID Connect and it should become the only way to use their solutions. https://medium.com/3box/introducing-3id-connect-531af4f84d3f

Perhaps the most important parts for this discussion:

Fewer wallet signatures 🔑 3ID Connect uses an HD trie to derive database keys for 3Box spaces from the user’s 3ID, so users only need to sign one message to consent to all permissions requested by an application instead of signing one message for each individual permission. Persistent 3Box sessions 🔁 3ID Connect allows users to persist 3Box sessions across application browser tabs, eliminating the need for users to sign into each individual tab.

I haven't yet dived into all of it and how it'll all work but this might be a concern, since I don't see Torus:

The following providers are initially supported; MetaMask and other injected providers, Fortmatic, Authereum, Portis, and WalletConnect.

As for speed, I am not sure how that IPFS early load would work, I would have to test that. Sounds promising though.

Chwy5 commented 4 years ago

worked on desktop for me but wont load on Mobile.... @matt-bullock try it worked the second time i tried Yeah seems to be working for me now

bconfortin commented 4 years ago

Are you on Android or iOS?

Em qua., 6 de mai. de 2020 às 18:07, Chwy5 notifications@github.com escreveu:

worked on desktop for me but wont load on Mobile.... @matt-bullock https://github.com/matt-bullock try it

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AugurProject/augur/issues/7500#issuecomment-624891511, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACO7DJOAO75HQXVZMJT6JUTRQHGQPANCNFSM4MSLEROA .

Chwy5 commented 4 years ago

No chrome android...

matt-bullock commented 4 years ago

Works for me. Closing