Closed nuliknol closed 4 years ago
here is the call parameters
withdraw all funds modal has 2 code paths.
If user's signing wallet has ETH withdrawAllFundsAsDai
will be called. It will convert the Fee reserve (ETH) to DAI and send to the user's destination address from the modal.
If the user's signing walllet doesn't have ETH then DAI will be transferred to the destination address in the modal using the GSN relayer. I don't think this will work if the account hasn't been activated. I'll need to test this scenario.
One issue could be we under estimated the DAI needed to transfer the user's DAI.
@nuliknol did you activate your trading account? looks like a transfer was tried so I assume no. I also assume you don't have any ETH in your signing wallet since a transfer was tried.
One thing I'm confused on is DAI faucet, it will fail if user hasn't activated trading account or doesn't have any ETH in signing wallet.
@nuliknol did you activate your trading account? looks like a transfer was tried so I assume no. I also assume you don't have any ETH in your signing wallet since a transfer was tried.
I do have ETH (on the EOA, not the Wallet contract), and while I didn't execute account activation by pressing the button, it does gets activated (because the button disappears after that from the screen) when you get REP and DAI from the faucet, and that's what I did.
So, I suppose the account was activated with Faucet transfer and I had DAI tokens on the Wallet contract when I attempted to transfer the funds.
@bthaile
First off, thanks for going through these hurdles, much appreciated.
We got in some changes in to withdraw all funds. There is one more coming in shortly but shouldn't affect your scenario. See if it works @nuliknol
@bthaile withdrawals are working fine! thank you!!
When trying to withdraw all funds from Wallet Contract by clicking "Withdraw" button on "ACCOUNT SUMMARY" page I get the error "gas required exceeds allowance".
This is using today's (morning) sources. Have you tested that withdrawal for local testnet is working?
Steps to reproduce:
Screenshot of the error attached
btw, it would be nice to have a popup dialog with the error text!