AugustoMarcelo / mcuapi

🦸 Marvel Cinematic Universe API
https://mcuapi.herokuapp.com/docs
67 stars 3 forks source link

Suggestion: Add IMDB id to response #10

Closed iZNunev closed 3 years ago

iZNunev commented 3 years ago

Hi,

I love the API and it does have sufficient stuff however, I would also like to build a personal app that has a bit more details, such as actors, additional images etc. Instead of adding those to the API it would be nice to have imdb_id for the movie/show returned so that we could make extra requests to movie databases to get extra info from there.

What do you think?

AugustoMarcelo commented 3 years ago

Hi, @iZNunev

Thanks for the feedback. I'm currently working to add some extra data like movies/tv shows related and characters. But your idea is interesting, I could add a column for external data. Could you give me an example value for the imdb_id?

iZNunev commented 3 years ago

Sure thing @AugustoMarcelo :) When you search a movie in the IMDB the ID appears as part of the URL: e.g Black widow: https://www.imdb.com/title/tt3480822/ the imdb_id in this case is tt3480822

AugustoMarcelo commented 3 years ago

Hi, @iZNunev

Sorry for the delay to return. But I have implemented your suggestion. Now, Movies and TV Shows have an imdb_id property!