AugustoMarcelo / mcuapi

🦸 Marvel Cinematic Universe API
https://mcuapi.herokuapp.com/docs
67 stars 3 forks source link

TV Shows Chronology #12

Closed Zizico2 closed 2 years ago

Zizico2 commented 2 years ago

Any chance you include the TV Shows into the chronological order?

AugustoMarcelo commented 2 years ago

Hi, @Zizico2

Thanks for the feedback! Do you say in relation to the TV Shows themselves or in relation to MCU in general?

Zizico2 commented 2 years ago

I say in relation to the MCU in general. Maybe a new field? Not to break applications using the current Chronology (the relative order would remain the same, but it could mess up people using the actual numbers)

Zizico2 commented 2 years ago

You could even add announced but not released titles to both movies and series and put "-1" in Chronology.

AugustoMarcelo commented 2 years ago

I say in relation to the MCU in general. Maybe a new field? Not to break applications using the current Chronology (the relative order would remain the same, but it could mess up people using the actual numbers)

That's a little tricky question. I might need to use decimal numbers for TV series that are between one movie and another. For example, a TV series that is chronologically between the 14th order movie and the 15th order movie would receive the value 14.1. Also, they are different models and have different routes.

AugustoMarcelo commented 2 years ago

You could even add announced but not released titles to both movies and series and put "-1" in Chronology.

This would affect the return of chronological order. That would put these movies and TV series ahead of the ones that have already been released.

Zizico2 commented 2 years ago

It would be a "magic number". If it is documented that "-1" means "we don't know when it is set", it is up to the client using the API to take that into consideration.