Aung-Phone-Naing / pe

0 stars 0 forks source link

Future dates are accepted in Add/Edit features #10

Open Aung-Phone-Naing opened 1 year ago

Aung-Phone-Naing commented 1 year ago

Users are able to input dates far into the future although the items were added under the normal "expense" and not the "future expense".

image.png

nus-se-bot commented 1 year ago

Team's Response

The user has the option to keep a record of both their paid and unpaid expenses in a single list. However, with the "future expense" feature, they can maintain a separate list for upcoming expenses that have not yet been paid and therefore have not affected their account balance. Additionally, the feature allows the user to record expenses that were due in the future but have already been paid as "current expenses" by specifying their original due date.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Future expense and expense

What is the purpose of having separate expense and future expense commands? image.png

Expenses can record past and future expenses:

image.png

Can just have the expenses command and remove future expenses commands altogether as they have same functionality for convenience.


[original: nus-cs2113-AY2223S2/pe-interim#2458] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

They serve different purposes, while the user may choose to track both their paid and unpaid expenses in one list, the future expense allows them to keep track of future unpaid expenses in a separate list, not having been deducted from their account balance.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** The team attempts to explain this now by stating that these two features serves different purposes, one for future expenses that are yet to be paid while the original command is for paid expenses. However, as shown in the screenshots below of their UG and DG, there are no justifications stating what purpose each of these features are for and also on how they can be used or the differences between them except for the fact that for `future expense` it demands for a `FUTURE_DATE` as the input while the normal `add expense` feature does not. Hence, this remains to be a valid bug that bothers users, especially first time users who are unclear of how to use the features to their advantage. ![image.png](https://raw.githubusercontent.com/Aung-Phone-Naing/pe/main/files/b4991799-02b0-496d-812c-629fa97da77a.png)
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]